2008-01-05 04:10 +0000 [r757490-757489] sebsauer * branches/KDE/4.0/kdelibs/kjsembed/kjsembed/qobject_binding.cpp: backport r757484+r757485: Fixed "cannot create 'UserType'" error reported by Ludger Sprenker. * branches/KDE/4.0/kdelibs/kjsembed/kjsembed/qobject_binding.cpp: forgot the include. sorry. 2008-01-05 19:19 +0000 [r757736] qbast * branches/KDE/4.0/kdelibs/khtml/rendering/render_form.cpp: Backport slot name fix 2008-01-05 19:41 +0000 [r757743] qbast * branches/KDE/4.0/kdelibs/kdecore/sonnet/filter.cpp: Backport assert fix from trunk 2008-01-06 00:37 +0000 [r757824] charles * branches/KDE/4.0/kdelibs/khtml/css/quirks.css: backport 2008-01-06 16:06 +0000 [r757952] mlaurent * branches/KDE/4.0/kdelibs/kfile/kfilewidget.cpp: Backport: don't use deprecated signal 2008-01-06 16:21 +0000 [r757955] mlaurent * branches/KDE/4.0/kdelibs/kfile/kdirselectdialog.cpp: Backport: don't use deprecated signal 2008-01-06 19:19 +0000 [r758026] tfry * branches/KDE/4.0/kdelibs/kate/syntax/data/doxygen.xml: Merge 758022 from trunk 2008-01-07 01:52 +0000 [r758156] jpetso * branches/KDE/4.0/kdelibs/kdeui/icons/kiconloader.cpp: Backport of r758155: Tune emblem sizes and don't use 12x12. 2008-01-07 06:56 +0000 [r758206] ppenz * branches/KDE/4.0/kdelibs/kio/kio/previewjob.cpp: Backport of fix for bug 154854 (trunk revision 757802): increase default preview size from 1 MB to 5 MB. 2008-01-08 12:16 +0000 [r758584] mlaurent * branches/KDE/4.0/kdelibs/kfile/kdiroperator.cpp: Don't use deprecated signal 2008-01-08 12:19 +0000 [r758585] craig * branches/KDE/4.0/kdelibs/security/crypto/crypto.cpp: Give file dialogs a parent. 2008-01-08 14:49 +0000 [r758614] whiting * branches/KDE/4.0/kdelibs/knewstuff/knewstuff2/ui/downloaddialog.cpp: backport dialog appearance fix 2008-01-08 22:28 +0000 [r758723] uwolfer * branches/KDE/4.0/kdelibs/kdeui/dialogs/kconfigdialog.cpp: Backport: SVN commit 758711 by uwolfer: it makes no sense to set an icon if none has been set 2008-01-09 00:41 +0000 [r758759] johnflux * branches/KDE/4.0/kdelibs/kio/kio/kdirwatch.cpp: Fix typo in #define 2008-01-09 06:50 +0000 [r758788] orlovich * branches/KDE/4.0/kdelibs/khtml/xml/dom2_eventsimpl.cpp: Fix a bad regression due to porting --- non-text key events were using a Qt-internal key ID and not browser-semi-independent one. KDE3.5.x used to use ->ascii() here, which would return 0 in case of special keys, making us use the m_virtKeyVal, as appropriate. But the misused here ->key would always return some value. So don't use it, and just use the event text() to find out unicode IDs of normal keys.. BUG:155319 2008-01-09 08:25 +0000 [r758800] orlovich * branches/KDE/4.0/kdelibs/khtml/xml/dom_elementimpl.cpp: Don't raise NOT_FOUND_ERROR exceptions from Element::removeAttribute... Another bad 4.0.0 regression from 3.5.x :( BUG:155320 2008-01-09 11:56 +0000 [r758849] ilic * branches/KDE/4.0/kdelibs/kdeui/dialogs/kmessagebox.cpp: i18n: filtering messages 2008-01-09 18:04 +0000 [r758960] ereslibre * branches/KDE/4.0/kdelibs/kate/utils/katepartpluginmanager.cpp, branches/KDE/4.0/kdelibs/kate/dialogs/katedialogs.cpp: Fix plugin (un)loading merging with GUI. This completely fixes KWrite. On Kate, since it has a slightly different way of working with plugins, this makes under certain circumstances some buttons of the main toolbar to be lost. Kate will have to be fixed. KWrite works like a charm. Backport from trunk. 2008-01-09 18:09 +0000 [r758964] ereslibre * branches/KDE/4.0/kdelibs/kate/utils/katepartpluginmanager.cpp: Backport from trunk. This also needs to be done when unloading a plugin. 2008-01-09 19:39 +0000 [r758995] tfry * branches/KDE/4.0/kdelibs/kate/document/katedocument.cpp: Merge 758994 from trunk. CCBUG: 155309 2008-01-09 20:40 +0000 [r759018] tfry * branches/KDE/4.0/kdelibs/kate/syntax/data/java.xml: Merge 759016 from trunk. CCBUG: 155248 2008-01-09 20:47 +0000 [r759026] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugdocument.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugdocument.h, branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugwindow.cpp: Fix the debugger crash spart noticed on 154420. We were killing source code information on eval fragments which had functions which escaped.. Inellegant, but effective CCBUG:154420 2008-01-10 17:42 +0000 [r759470] orlovich * branches/KDE/4.0/kdelibs/kioslave/http/http.cpp: Parse content-disposition better; at the very least not including the =, ", and last ". Also makes a likely ill-advised attempt to do it following the spec, which at least should make it more tolerant to LWS BUG:153693 CCBUG:155276 2008-01-10 17:53 +0000 [r759473] orlovich * branches/KDE/4.0/kdelibs/kio/kio/slavebase.cpp, branches/KDE/4.0/kdelibs/kio/kio/slavebase.h: Make sure that ->config() doesn't end up with stale metadata. Fixes e.g. infinite looping on LiveJournal friends page, and heaven knows what else. BUG: 153538 2008-01-10 18:56 +0000 [r759492] tfry * branches/KDE/4.0/kdelibs/kate/syntax/data/erlang.xml, branches/KDE/4.0/kdelibs/kate/tests/highlight.erl (added): Merge 759490 from trunk. CCBUG: 155322 2008-01-10 19:13 +0000 [r759507] ppenz * branches/KDE/4.0/kdelibs/kfile/kdirsortfilterproxymodel.cpp: Backport of bugfix 154602: Fixed wrong sorting of the date column inside Dolphin and Konqueror (1.1.2007 is defined to be smaller than 1.1.2008). CCMAIL: ereslibre@kde.org 2008-01-10 21:38 +0000 [r759579] uwolfer * branches/KDE/4.0/kdelibs/kdeui/dialogs/kaboutapplicationdialog.cpp: Backport: SVN commit 759576 by uwolfer: Fix crash when the constructor was called with aboutData == 0. Reported by dato on IRC. 2008-01-10 22:45 +0000 [r759610] lunakl * branches/KDE/4.0/kdelibs/kdeui/windowmanagement/kwindowsystem_x11.cpp: Avoid an infinite loop caused by the KWindowSystemPrivate ctor emitting signals before it finishes and the pointer to it is not yet set. 2008-01-10 23:08 +0000 [r759623-759621] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_window.cpp, branches/KDE/4.0/kdelibs/khtml/khtml_part.cpp: Fix KJS_VERBOSE build... * branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugdocument.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugdocument.h, branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugwindow.cpp: - Fix crash when no context is active in console - Restore better context-finding code. This is much more useful this way.. * branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugwindow.cpp: Yikes. Another small change producing a big bug. Make sure that exceptionToString doesn't "restore" the exception object being serialized into the global ExecState. That was correct within ::exception in debugger, but not from the general error log. Brown paper bag time for me. Makes the frontpage of software.opensuse.org show up fine for me... Andras, does it fix the problem you were seeing? CCBUG:155423 2008-01-11 09:20 +0000 [r759747] mlaurent * branches/KDE/4.0/kdelibs/kdeui/widgets/khelpmenu.cpp: Backport: don't add switch language menu when we have just one language on computer 2008-01-11 19:59 +0000 [r760045] orlovich * branches/KDE/4.0/kdelibs/kdeui/sonnet/highlighter.h, branches/KDE/4.0/kdelibs/kdeui/sonnet/highlighter.cpp: Fix some of the major performance problems this causes in textareas in KHTML by not computing spelling correction suggestions when none are needed, as they are extremely expensive to compute... Doesn't help kmail since it does connect the signal... A better option would be to do the computation on demand. Also fix a clear logic error, and making word counting make sense some of the time and not none of the time. This class needs heavy work, however. It rehighlights the entire document when one presses enter. The word counting is still bogus between rehighlights. It hardcodes black when switching the error off... IOW, it needs love from someone with good understanding of QSyntaxHighlighter 2008-01-11 23:58 +0000 [r760132] aacid * branches/KDE/4.0/kdelibs/kfile/kfilewidget.cpp: backport r760130 **************** we also need to check for the current extension so that in case the current extension is a .foo.bar we don't duplicate .foo lastExtension is there for a similar purpose but only when changing the current file type thorugh the combo 2008-01-12 03:59 +0000 [r760170] porten * branches/KDE/4.0/kdelibs/kjs/lexer.h, branches/KDE/4.0/kdelibs/kjs/lexer.cpp: Perform check of valid identifier chars for unicode escape sequences, too. Fixes an Acid3 test. Incorporated JSC r29075. 2008-01-12 05:05 +0000 [r760175] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugwindow.cpp: Fix a crash in the debugger when we were getting a clear request on interpreter that we never attached to. 2008-01-12 11:39 +0000 [r760258-760256] mkruisselbrink * branches/KDE/4.0/kdelibs/cmake/modules/KDE4Macros.cmake: backport 759619: make kde4_add_unit_test work properly on OSX together with non-NOGUI tests. I'm not entirely convinced this is the best way to fix it, but it seems to work fine (and it is at least better than the current situation). * branches/KDE/4.0/kdelibs/kdeui/actions/kstandardaction.cpp: backport 759620: set correct MenuRole's on KStandardAction's; this should improve which menu items are moved to the Application menu on OSX. 2008-01-12 15:21 +0000 [r760409] porten * branches/KDE/4.0/kdelibs/kjs/JSImmediate.h, branches/KDE/4.0/kdelibs/kjs/value.h: Used some JSC noise to practise with Emacs' merge feature. 2008-01-12 16:38 +0000 [r760427] orlovich * branches/KDE/4.0/kdelibs/kjs/internal.cpp: Don't call toString on objects in the debug/KJS_VERBOSE method printInfo, as that may invoke custom serializations from users, and hence is unsuitable for tracing use... 2008-01-12 16:39 +0000 [r760429] winterz * branches/KDE/4.0/kdelibs/cmake/modules/MacroLogFeature.cmake: backport SVN commit 760423 by winterz: - if all packages were found, provide a message saying so - cleanup the output a little. - not all found packages are optional; some are required. so reduce confusion by saying "external" instead. 2008-01-12 19:06 +0000 [r760479] porten * branches/KDE/4.0/kdelibs/kjs/object.cpp, branches/KDE/4.0/kdelibs/kjs/object.h, branches/KDE/4.0/kdelibs/kjs/internal.cpp, branches/KDE/4.0/kdelibs/kjs/value.cpp, branches/KDE/4.0/kdelibs/kjs/number_object.cpp, branches/KDE/4.0/kdelibs/kjs/wtf/Assertions.h, branches/KDE/4.0/kdelibs/kjs/JSImmediate.h, branches/KDE/4.0/kdelibs/kjs/internal.h, branches/KDE/4.0/kdelibs/kjs/value.h: Merged in lots of renamed and new number handling functions from JSC. Should not make a functional difference apart of a Acid3 fix hidden in the Number reordering. 2008-01-12 21:36 +0000 [r760527] uwolfer * branches/KDE/4.0/kdelibs/kdeui/dialogs/kdialog.cpp: Backport: SVN commit 760522 by uwolfer: Try to set a proper inital help name. 2008-01-12 21:37 +0000 [r760528] porten * branches/KDE/4.0/kdelibs/kjs/interpreter.cpp, branches/KDE/4.0/kdelibs/kjs/lexer.h, branches/KDE/4.0/kdelibs/kjs/function.cpp, branches/KDE/4.0/kdelibs/kjs/grammar.cpp, branches/KDE/4.0/kdelibs/kjs/interpreter.h, branches/KDE/4.0/kdelibs/kjs/nodes.cpp, branches/KDE/4.0/kdelibs/kjs/tests/testkjs.cpp, branches/KDE/4.0/kdelibs/kjs/function_object.cpp, branches/KDE/4.0/kdelibs/kjs/ustring.cpp, branches/KDE/4.0/kdelibs/kjs/Parser.cpp, branches/KDE/4.0/kdelibs/kjs/grammar.y, branches/KDE/4.0/kdelibs/kjs/lexer.cpp, branches/KDE/4.0/kdelibs/kjs/ustring.h, branches/KDE/4.0/kdelibs/kjs/Parser.h: Merged in r27842 from JSC. Mostly an API redesign. 2008-01-12 21:57 +0000 [r760538] porten * branches/KDE/4.0/kdelibs/kjs/array_object.cpp: The semantics of toInteger() changed with the latest JSC patch. 2008-01-12 23:45 +0000 [r760570] orlovich * branches/KDE/4.0/kdelibs/kjs/fpconst.cpp: automatically merged revision 760525: Fix missing NaN symbol reference for linkage 2008-01-13 01:35 +0000 [r760596] porten * branches/KDE/4.0/kdelibs/kjs/lexer.h, branches/KDE/4.0/kdelibs/kjs/wtf/Vector.h, branches/KDE/4.0/kdelibs/kjs/ustring.cpp, branches/KDE/4.0/kdelibs/kjs/lexer.cpp, branches/KDE/4.0/kdelibs/kjs/ustring.h: Use ready-made container classes (JSC r27859). 2008-01-13 02:47 +0000 [r760608] porten * branches/KDE/4.0/kdelibs/kjs/date_object.cpp: Improper NaN/missing arg handling uncovered by Acid 3 test. 2008-01-13 16:58 +0000 [r760898] ilic * branches/KDE/4.0/kdelibs/kdeui/dialogs/kmessagebox.cpp: Remove unnecessary Q_UNUSED(). 2008-01-13 17:17 +0000 [r760904] porten * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_proxy.cpp: Fixed crash on call of an internal debugging function. 2008-01-13 17:22 +0000 [r760907] reed * branches/KDE/4.0/kdelibs/cmake/modules/FindKDE4Internal.cmake: backport FULL_RPATH osx fix to 4.0 2008-01-13 18:41 +0000 [r760932] orlovich * branches/KDE/4.0/kdelibs/kjs/regexp_object.h, branches/KDE/4.0/kdelibs/kjs/regexp.cpp, branches/KDE/4.0/kdelibs/kjs/CMakeLists.txt, branches/KDE/4.0/kdelibs/kjs/string_object.cpp, branches/KDE/4.0/kdelibs/kjs/regexp.h, branches/KDE/4.0/kdelibs/kjs/regexp_object.cpp: Limit stack usage of libPCRE (and raise an exception when it runs out of stack space, for diagnosibility). Also, do not accept some super old (>4 year old) pcre versions; as they can severely cripple regexp support, and intefere with this bugfix. Also tweak the message about missing PCRE in configure check --- libPCRE doesn't result in "better" regexp support; the support w/o it is a last-resort fallback... Based on patch by Sune Vuorela (username debian, hostname pusling, tld com) BUG:149191 BUG:151477 2008-01-13 18:48 +0000 [r760936] porten * branches/KDE/4.0/kdelibs/khtml/xml/dom2_rangeimpl.cpp: Fix cloning and extracting of collapsed ranges. 2008-01-13 19:30 +0000 [r760951] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugwindow.cpp: Make syntax error messages less useless. String is from old debugger, and not new... 2008-01-13 20:56 +0000 [r760977] porten * branches/KDE/4.0/kdelibs/khtml/xml/dom2_rangeimpl.cpp: I am not sure I can interpret this from the wording of the spec. But if insertNode() of the Range interface should actually insert a node into the range we'll have to extend it. Found in an Acid3 test that inserted a node in collapsed range. 2008-01-14 02:25 +0000 [r761091-761087] orlovich * branches/KDE/4.0/kdelibs/khtml/rendering/render_frames.h, branches/KDE/4.0/kdelibs/khtml/khtml_part.cpp, branches/KDE/4.0/kdelibs/khtml/rendering/render_frames.cpp: - Remove hacks for activeX/reaktivate, in preparation for major object/iframe fixes work... * branches/KDE/4.0/kdelibs/khtml/rendering/render_replaced.cpp, branches/KDE/4.0/kdelibs/khtml/rendering/render_replaced.h: Permit RenderWidget subclasses to defer memory management of the widget to the DOM. Needed for iframe's, etc., to be managed by the DOM and not the renderer * branches/KDE/4.0/kdelibs/khtml/khtml_part.h, branches/KDE/4.0/kdelibs/khtml/khtmlpart_p.h, branches/KDE/4.0/kdelibs/khtml/rendering/render_frames.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_html.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_objectimpl.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_window.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_baseimpl.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_objectimpl.h, branches/KDE/4.0/kdelibs/khtml/khtml_part.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom_docimpl.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_baseimpl.h, branches/KDE/4.0/kdelibs/khtml/rendering/render_frames.cpp: Move object loading to the DOM from the renderer, fixing the long-standing major bug that hidden iframes couldn't be interacted with. The basic overview here is that a new DOM base class, HTMLPartContainerElementImpl is created, that manages the interaction with KHTMLPart when it comes to loading child parts. KHTMLPart now keeps tracks of those per ChildFrame (along the way removing the confusion of having 2 m_frames in close quarters talking about different things); and the DOM objects for iframe/object/embed/frame/etc. request the loading themselves as needed. The renderer "just" displays the part widget set from the DOM BUG: 71809 BUG: 150240 (and probably others) * branches/KDE/4.0/kdelibs/khtml/html/html_objectimpl.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_objectimpl.h: Fix applet problems: - compute URL in computeNeeded, not attach() - wait until paramets are there - promptly cleanup to avoid assert failures on exit... * branches/KDE/4.0/kdelibs/khtml/html/html_objectimpl.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_objectimpl.h, branches/KDE/4.0/kdelibs/khtml/khtml_part.cpp: - Make sure we handle image-type objects as RenderImage even when the mimetype is not explicitly given, by giving the dom a chance to cancel the request and do its own thing when processObjectRequest is called from KHTMLRun.. fixes css21/t0801-c412-hz-box-00-b-a.html - Fix a crasher caused by immediate deletion of objects in part container base.. Better just clean the objects in KHTMLPart, like we do for frames 2008-01-14 02:54 +0000 [r761100] orlovich * branches/KDE/4.0/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp: Fix some assertion-failures in the cookie jar (and hence kded4) (though one more needs further thought) 2008-01-14 05:04 +0000 [r761121] orlovich * branches/KDE/4.0/kdelibs/khtml/css/css_valueimpl.cpp: Don't improperly round fp values when serializing to cssText (e.g. turning opacity:0.5 into opacity:0). Fixes a whole bunch of failures on the jQuery testsuite. 2008-01-14 19:15 +0000 [r761399] uwolfer * branches/KDE/4.0/kdelibs/kdeui/dialogs/kdialog.cpp, branches/KDE/4.0/kdelibs/kdeui/dialogs/kconfigdialog.cpp: Backport: SVN commit 761396 by uwolfer: Less general fix than rev 760522, but this one should not break kcmodules. Thanks Laurent for the comments. 2008-01-14 20:09 +0000 [r761421] orlovich * branches/KDE/4.0/kdelibs/kjs/regexp.cpp, branches/KDE/4.0/kdelibs/kjs/CMakeLists.txt: (Hopefully) - Fix builds with pcre in a subdir - Fix non-pcre builds --- but make them require passing a special parameter, since they're heavily broken. Shame CMake doesn't have a feature requiring signing off to a disclaimer. In blood. Thanks to apaku for help. BUG:155738 2008-01-14 23:31 +0000 [r761496] ilic * branches/KDE/4.0/kdelibs/kdecore/localization/klocale.cpp: Better consideration of environment variables when initializing languages; tighter use of transliteration fallbacks. 2008-01-15 01:31 +0000 [r761523] porten * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_binding.cpp: Include human-readable code of DOM exceptions. CSSExceptions are dead? 2008-01-15 11:00 +0000 [r761710] lunakl * branches/KDE/4.0/kdelibs/kdeui/dialogs/kdialog.cpp: QWidget::windowFlags() is half enum, half bitfield ... interesting ... BUG: 155554 2008-01-15 16:38 +0000 [r761906] rjarosz * branches/KDE/4.0/kdelibs/kde3support/kdeui/k3listview.cpp: Backport r761905. Always accept drag otherwise contentsDragMoveEvent won't be emitted. 2008-01-15 20:18 +0000 [r761979-761978] orlovich * branches/KDE/4.0/kdelibs/khtml/xml/dom_elementimpl.cpp: Don't crash cloning elements with both inline and non-CSS style information where the inline information was created directly, and not from a style= attribute. Fixes zeit.de, #153711 BUGNO:153711 * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom_elementimpl.h: Properly handle DOMImplementation::createDocument(null, null, null) --- don't convert the first 2 to "null", "null", and make checkQualifiedName not crash in that case. (Shows up on acid3) 2008-01-15 20:33 +0000 [r761986] braxton * branches/KDE/4.0/kdelibs/kdecore/config/kconfigini.cpp: backport r761977 2008-01-15 21:39 +0000 [r762010] amantia * branches/KDE/4.0/kdelibs/kdeui/kernel/kstyle.cpp: Backport r761987: Return the real values for tabbar active tab shifting, so the close button on the tabs can be painted correctly. 2008-01-16 00:08 +0000 [r762051] mueller * branches/KDE/4.0/kdelibs/kjs/scope_chain.cpp: compile++ 2008-01-16 00:08 +0000 [r762052] orlovich * branches/KDE/4.0/kdelibs/kjs/string_object.cpp: Fix single-argument String.prototype.substr(3). Actually, go ahead and merge JSC's version of the method, minus the obvious dead variable and its misuse. It's much simpler due to relying on the newer toInteger semantics, and is clearly functionally identical to what I wrote following the spec... Fixes the $= selector in JQuery 2008-01-16 01:45 +0000 [r762074] porten * branches/KDE/4.0/kdelibs/kjs/wtf/AlwaysInline.h: Feature was buggy/incomplete in some gcc 3 versions. BUG: 155811 2008-01-16 14:15 +0000 [r762197] dhaumann * branches/KDE/4.0/kdelibs/kate/syntax/data/lua.xml: DoxygenLua.xml is missing -> remove in 4.0, add for 4.1 2008-01-16 19:41 +0000 [r762307] ppenz * branches/KDE/4.0/kdelibs/kio/kfile/kicondialog.cpp: Backport of bugfix for 153493: Fixed issue that inside the .directory file the full path of an icon is given: Icon=/home/jakob/dev/kde/install/kde/share/icons/oxygen/48x48/places/user-desktop.png instead of Icon=user-desktop The full path leads to a blurry icon when showing the icon in an increased size (e. g. in the Dolphin information bar). 2008-01-16 21:12 +0000 [r762348] sebsauer * branches/KDE/4.0/kdelibs/kjsembed/kjsembed/qobject_binding.h: backport r762347: export that function 2008-01-16 21:19 +0000 [r762354] sebsauer * branches/KDE/4.0/kdelibs/kross/kjs/kjsscript.cpp: backport r762350+762352: fix problem with passing in QObject/QWidget as arguments 2008-01-16 22:45 +0000 [r762398] dfaure * branches/KDE/4.0/kdelibs/kdecore/kernel/kauthorized.cpp: I was right when I wrote the first line of this comment: there is no reason for this assert to be here at all, KAuthorized works fine without an applicationName. KGlobal doesn't need one to get a config file (it needs a componentData instead); the only fallback to applicationName in KGlobal is in KGlobal::caption() which is completely irrelevant... BUG: 155700 2008-01-16 22:58 +0000 [r762406] dfaure * branches/KDE/4.0/kdelibs/kdeui/windowmanagement/kwindowsystem_x11.cpp: Fix warning from e.g. kfmclient; kapp shouldn't be a requirement just because KRun calls KWindowSystem::currentDesktop(). QObject::connect: Cannot connect QWidget::destroyed() to (null)::_k_x11FilterDestroyed() 2008-01-16 23:08 +0000 [r762408] porten * branches/KDE/4.0/kdelibs/khtml/khtml_part.cpp: Merged revision 761605: If a frame is an IFrame, always embed its content, do not show a "save or embed dialog". Prevents multiple dialogs from popping up when visiting netvibes.com. Approved by Germain Garand. 2008-01-17 07:53 +0000 [r762468] orlovich * branches/KDE/4.0/kdelibs/khtml/html/html_headimpl.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_headimpl.h, branches/KDE/4.0/kdelibs/khtml/misc/loader.cpp, branches/KDE/4.0/kdelibs/khtml/misc/loader.h: For jQuery: support onload on script elements, so we can get past test 105. Partial merge from WC, minus code duplication, plus comments. One thing I am not sure of: do we want to do error event as well? I am not a fan of 50% legacy, 50% proprietary events that bubble. 2008-01-17 16:02 +0000 [r762652] lunakl * branches/KDE/4.0/kdelibs/kdeui/util/kmanagerselection.cpp: Sync when checking for errors. BUG: 155336 2008-01-17 16:22 +0000 [r762656] pino * branches/KDE/4.0/kdelibs/cmake/modules/FindSharedMimeInfo.cmake: Raise the "warning level" to shared-mime-info 0.20. 2008-01-17 17:33 +0000 [r762684] orlovich * branches/KDE/4.0/kdelibs/khtml/rendering/render_form.cpp, branches/KDE/4.0/kdelibs/khtml/rendering/render_form.h: Do not emit onchange on synthetic toggling of radio buttons and checkboxes. That's incompatible, and also led to #155973, crash on the beta BBC's page location selector, as we have the following scenario: 1. JS sets checked. 2. We do updateFromElement, ask Qt to update the widget 3. The widget emits the change signal 4. The change signal handler does ref() [rc = 2] 5. The change signal handler does onchange(). The event running causes a detach, which does a deref() [rc = 1] 6. The change signal handler does deref() [rc = 0], so the Render* gets destroyed 7. The common parts of updateFromElement, such as RenderWidget::updateFromElement, etc., run on a deleted RenderCheckBox/RadioButton, trying to access deleted RenderStyle, etc. boom. BUG: 155973 2008-01-17 18:20 +0000 [r762708] lunakl * branches/KDE/4.0/kdelibs/kdeui/util/kmanagerselection.cpp: Sync when checking for errors, attempt #2. 2008-01-17 19:03 +0000 [r762725] uwolfer * branches/KDE/4.0/kdelibs/kfile/kfilewidget.cpp: Backport: SVN commit 762724 by uwolfer: Set the lineedit modified when it has been modified by the user. This way pasted paths/files get opened instead of the last selected in the file view (reproducible in KWrite when already one file has been opened). #155356 2008-01-17 19:14 +0000 [r762729] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/xmlhttprequest.cpp: Set prototype on the XHR ctor... 2008-01-17 20:21 +0000 [r762757] orlovich * branches/KDE/4.0/kdelibs/khtml/html/html_formimpl.cpp: Make button's type handling make more sense, passing 1 more Acid3 testcase. Matches Opera and WF2.0 behavior, not Mozilla one, since it is far more logical and consistent... 2008-01-17 20:35 +0000 [r762767] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_html.cpp, branches/KDE/4.0/kdelibs/khtml/css/css_renderstyledeclarationimpl.cpp: Object.data should return URL, not a string... Fixes acid3 test 64... 2008-01-17 20:42 +0000 [r762770] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.cpp, branches/KDE/4.0/kdelibs/khtml/css/css_renderstyledeclarationimpl.cpp: Revert these parts, didn't want to commit them, not ready yet. 2008-01-18 02:10 +0000 [r762873] orlovich * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.h, branches/KDE/4.0/kdelibs/khtml/khtml_run.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Merge in Fredrik's canvas work and agateau's netvibes fixes from trunk. The only non-debugger functional difference now should be njaard's BiDi fix.. 2008-01-18 03:07 +0000 [r762875] orlovich * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: 'darker' is no longer in the spec. 2008-01-18 03:18 +0000 [r762877] porten * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_range.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_window.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_binding.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_range.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_window.h: Implement a proper RangeException object with pseudo constructor and prototype holding the error code constant. setDOMException() will be cleaned up once all DOM errors are done this way. 2008-01-18 05:39 +0000 [r762887] porten * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.cpp: The namespaceUri can be specified to be null. In case the qualifiedName then has a prefix we'll throw an NAMESPACE_ERR exception. 2008-01-18 05:59 +0000 [r762890] porten * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_binding.cpp: Make DOMException an object type of its own. Still todo: harmonize exception objects and properties. 2008-01-18 10:14 +0000 [r763005] woebbe * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_range.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.h: -pedantic 2008-01-18 12:09 +0000 [r763045-763044] dfaure * branches/KDE/4.0/kdelibs/kdecore/MAINTAINERS: remove Waldo's "big name" :-) * branches/KDE/4.0/kdelibs/kdeui/MAINTAINERS: Remove Waldo's big name, remove keditcl[12] 2008-01-18 17:28 +0000 [r763133] lunakl * branches/KDE/4.0/kdelibs/kdeui/shortcuts/kglobalaccel_x11.cpp, branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel.cpp, branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel.h: Since calling directly Xlib's XGrabKeyboard() is very unlikely and even probably undesired in kded, make KGlobalAccel again ungrab when there's no Qt caused grab. BUG: 153211 2008-01-18 17:50 +0000 [r763136] dfaure * branches/KDE/4.0/kdelibs/kdecore/tests/klocaletest.cpp: I don't know why the timezone isn't available here, but it makes the test fail, so test for it. 2008-01-18 20:26 +0000 [r763178] dfaure * branches/KDE/4.0/kdelibs/kdecore/tests/kfiltertest.cpp, branches/KDE/4.0/kdelibs/kdecore/tests/kmimetypetest.cpp, branches/KDE/4.0/kdelibs/kdecore/compression/kfilterbase.cpp: Fix KFilterDev for mimetypes that derive from application/x-gzip or x-bzip. Bug found when reading extragear/graphics/ligature/shell/ligaturepart.cpp (tell me next time instead of adding workarounds :-) 2008-01-18 21:14 +0000 [r763193] ppenz * branches/KDE/4.0/kdelibs/kio/kio/kfileitemdelegate.cpp: Backport: Only use the cache if the size is equal to the current item size. This fixes drawing artifacts when zooming in or out inside Dolphin or Konqi. CCMAIL: fredrik@kde.org 2008-01-18 23:15 +0000 [r763239] dfaure * branches/KDE/4.0/kdelibs/kdecore/sycoca/ksycoca.h, branches/KDE/4.0/kdelibs/kdecore/tests/kmimetypetest.cpp, branches/KDE/4.0/kdelibs/kdecore/services/kmimetype.cpp, branches/KDE/4.0/kdelibs/kdecore/services/kmimetype_p.h, branches/KDE/4.0/kdelibs/kdecore/services/kmimetype.h: XDG shared-mime-info specifies that a mimetype can inherit from more than one mimetype; this was overlooked and for this reason KMimeType::mimeType("application/x-shellscript")->is("application/x-executable") returned false, which broke KRun(some_shell_script). 2008-01-18 23:34 +0000 [r763245] aacid * branches/KDE/4.0/kdelibs/kdeui/itemviews/ktreewidgetsearchline.cpp: Backport r763244 **************** Fix regression from KDE 3.5 As the comment says // can't call createWidgets directly because it calls virtual functions // that might not work if called directly from here due to how inheritance works 2008-01-18 23:41 +0000 [r763248-763246] orlovich * branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.h, branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.cpp: Simplify and robustify the TreeWalker implementation somewhat, fixing a couple of bugs along the way. It actually seems very close to right (unlike the utterly wrong impl WebCore has :-) ) * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_traversal.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.cpp: - It helps to call the right method in the bindings - Fix bug in getPreviousNode, and my complete botching of getParentNode. Now acid3 test 6 passes (test 5 still needs work) * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_traversal.cpp, branches/KDE/4.0/kdelibs/khtml/dom/dom2_traversal.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_traversal.h, branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.cpp, branches/KDE/4.0/kdelibs/khtml/dom/dom2_traversal.h: Make node filters work in JS. Uff. Now all the treewalker tests in acid3 pass. Remove some dead/commented-out stuff in dom2_traversal.*, which came from misunderstanding of the role of DocumentTraversal interface.. tweak a comment 2008-01-19 11:41 +0000 [r763406] uwolfer * branches/KDE/4.0/kdelibs/kdeui/dialogs/kbugreport.cpp: Backport: SVN commit 763405 by uwolfer: * Fix crash: do not try to set text to a not created text edit. * QTextEdit -> KTextEdit 2008-01-19 12:33 +0000 [r763431] aacid * branches/KDE/4.0/kdelibs/kdeui/itemviews/ktreewidgetsearchline.cpp: backport r763430 **************** use the correct way of passing a parameter to invokeMethod, sorry for breaking it 2008-01-19 17:41 +0000 [r763527] alexmerry * branches/KDE/4.0/kdelibs/includes/KPrintPreview (added), branches/KDE/4.0/kdelibs/includes/CMakeLists.txt: C++-style include. My bad for not committing months ago. 2008-01-19 17:41 +0000 [r763529-763528] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_binding.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_binding.cpp: Properly coalesce wrappers accross documents. This requires having a global map for hashconsing along with the previous local wrapper maps used for memory management. (We also have to be careful to insert into local maps when reusing from global ones). BUG: 145775 * branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_traversal.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.cpp: - Audit for robustness and simplify the NodeIterator code. Much of the code it had duplicated NodeImpl::traverseNextNode/::traversePreviousNode Use very descriptive position constants vs. the ambiguous m_beforeNode (which - Fix a bug in how we move the reference node to the right after large chunks containing it were removed. 2008-01-19 18:41 +0000 [r763553] porten * branches/KDE/4.0/kdelibs/khtml/xml/dom_docimpl.cpp: Basic cloneNode() implementation for Document and DocumentType. 2008-01-19 21:36 +0000 [r763605] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom_docimpl.cpp: - We do support DOM2 traversal, so advertise that - Remove the hack in handling of null for version, and fix it properly. 2008-01-19 22:35 +0000 [r763615] porten * branches/KDE/4.0/kdelibs/khtml/xml/dom_elementimpl.h: The following rules from the XML namespace grammar disallow non-empty prefixes: [6] QName ::= (Prefix ':')? LocalPart [7] Prefix ::= NCName [4] NCName ::= (Letter | '_') (NCNameChar)* Fixes an Acid3 test. 2008-01-20 00:36 +0000 [r763644] porten * branches/KDE/4.0/kdelibs/khtml/xml/dom_elementimpl.h: We missed some namespace checking in createElementNS() and createAttributeNS(). Function size is unhealthy now. 2008-01-20 01:03 +0000 [r763652-763651] lunakl * branches/KDE/4.0/kdelibs/kdeui/util/kxerrorhandler.h, branches/KDE/4.0/kdelibs/kdeui/util/kxerrorhandler.cpp: Use XErrorEvent for error reporting. * branches/KDE/4.0/kdelibs/kdeui/util/kxerrorhandler.h, branches/KDE/4.0/kdelibs/kdeui/util/kxerrorhandler.cpp: Function that reports details about an X error and it tries quite hard. 2008-01-20 01:32 +0000 [r763658] porten * branches/KDE/4.0/kdelibs/khtml/dom/dom_element.cpp: a bit of validity checking 2008-01-20 01:41 +0000 [r763662] lunakl * branches/KDE/4.0/kdelibs/kdeui/util/kxerrorhandler.cpp: Fixes, better output. 2008-01-20 02:25 +0000 [r763667] lunakl * branches/KDE/4.0/kdelibs/kdeui/util/kxerrorhandler.cpp: Core errors are not unknown. 2008-01-20 02:50 +0000 [r763670] porten * branches/KDE/4.0/kdelibs/kjs/nodes.cpp: Note sure why I ever thought that the constructor property of function objects would be immutable. Maybe based on a previous spec? 2008-01-20 06:53 +0000 [r763682-763681] orlovich * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_traversal.cpp, branches/KDE/4.0/kdelibs/khtml/dom/dom2_traversal.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_traversal.h, branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.cpp: - Properly propagate exceptions from the filter. Uglyyyy (but needed) - Properly raise exception in TreeWalkerImpl::setCurrentNode No real improvement on acid3 results, but I think that's because the tests it still fails are wrong (though I didn't look at one yet..) * branches/KDE/4.0/kdelibs/khtml/imload/canvasimage.cpp, branches/KDE/4.0/kdelibs/khtml/imload/imageformat.h, branches/KDE/4.0/kdelibs/khtml/imload/image.cpp: Fix problems with scaling of canvas. It wasn't setting up the format right descriptor at all. Remove related braindeadness in scaling plane setup code, which for some reason likely related to coding way too late (checks clock) was making temp QImages. 2008-01-20 08:29 +0000 [r763696] mlaurent * branches/KDE/4.0/kdelibs/kdeui/sonnet/highlighter.cpp: Backport: Clean qhash 2008-01-20 08:52 +0000 [r763700] ossi * branches/KDE/4.0/kdelibs/kpty/kpty.cpp, branches/KDE/4.0/kdelibs/ConfigureChecks.cmake, branches/KDE/4.0/kdelibs/config-pty.h.cmake: backport netbsd compile fix 2008-01-20 09:31 +0000 [r763706] mlaurent * branches/KDE/4.0/kdelibs/kdeui/sonnet/highlighter.cpp: Reverse it crashs 2008-01-20 20:42 +0000 [r764022] dfaure * branches/KDE/4.0/kdelibs/kdeui/xmlgui/kxmlguifactory.cpp: less noise when using konsole 2008-01-20 21:41 +0000 [r764044] porten * branches/KDE/4.0/kdelibs/khtml/xml/dom2_rangeimpl.cpp: Fixed insertion of a text node into a range in another one. The expected result is a bit unclear in the spec. I harmonized some code with WebCore but went for compatibility with Firefox 3. 2008-01-20 22:13 +0000 [r764067] orlovich * branches/KDE/4.0/kdelibs/kdeui/kernel/kstyle.cpp: Honor tab text color BUG:154894 2008-01-21 12:04 +0000 [r764306] mlaurent * branches/KDE/4.0/kdelibs/kdecore/sonnet/settings.cpp: Backport: Don't add ignore_ entry empty 2008-01-21 12:08 +0000 [r764308] mlaurent * branches/KDE/4.0/kdelibs/kdecore/sonnet/settings.cpp: Backport: don't add empty list 2008-01-21 12:50 +0000 [r764321] mlaurent * branches/KDE/4.0/kdelibs/kdecore/sonnet/settings.cpp: Backport my error 2008-01-21 13:46 +0000 [r764339] dfaure * branches/KDE/4.0/kdelibs/kio/kfile/kpreviewprops.cpp, branches/KDE/4.0/kdelibs/kio/kfile/kfilemetapreview.cpp: Hide preview tab from properties dialog when it's going to be empty (kde3 bug, too). Remove dead code from kfilemetapreview.cpp, add comment. 2008-01-21 15:49 +0000 [r764374] orlovich * branches/KDE/4.0/kdelibs/kjs/lexer.cpp: Handle the BOM like IE does, as a whitespace char. Spec-wise, it should be stripped along with the other Cf characters, but we know that breaks websites; further testing of IE and FF behavior suggests that they basically agree on nothing.. Needed on tvguide.com frontpage.. 2008-01-21 19:39 +0000 [r764442] andrunko * branches/KDE/4.0/kdelibs/kfile/kfileplacesview.cpp: Make sure the item size is computed when a new row is inserted. 2008-01-21 22:40 +0000 [r764485] uwolfer * branches/KDE/4.0/kdelibs/kio/kfile/kpropertiesdialog.cpp: Backport: SVN commit 764484 by uwolfer: Fix: respect comboboxes values again when setting file permissions 2008-01-21 23:29 +0000 [r764497] lukas * branches/KDE/4.0/kdelibs/kdeui/widgets/kcharselectdata.cpp, branches/KDE/4.0/kdelibs/kdeui/widgets/kcharselect-translation.cpp: correctly translate the block and section names 2008-01-22 09:48 +0000 [r764643] lueck * branches/KDE/4.0/kdelibs/kdoctools/customization/entities/general.entities: changed okular->Okular, approved by pino 2008-01-22 10:35 +0000 [r764677] trueg * branches/KDE/4.0/kdelibs/nepomuk/core/ui/kratingwidget.cpp: Emit the ratingChanged signal and thus, make Dolphin update the rating in the resource which results in saving the rating. BUG: 156341 2008-01-22 16:50 +0000 [r764816] winterz * branches/KDE/4.0/kdelibs/cmake/modules/KDE4Macros.cmake: backport SVN commit 764809 by winterz: patch by dfaure so that the testfoo.shell wrapper is used when running 'make test' on Unix. We want to do this because testfoo.shell uses the runpath that points to our builddir, rather than installdir. this way, you no longer need to run make install before running make test. as discussed on kde-buildsystem 2008-01-22 19:18 +0000 [r764875] whiting * branches/KDE/4.0/kdelibs/knewstuff/knewstuff2/ui/kdxsbutton.cpp: backport missing break; statement 2008-01-22 20:17 +0000 [r764896] lunakl * branches/KDE/4.0/kdelibs/kdeui/tests/kmainwindow_unittest.cpp, branches/KDE/4.0/kdelibs/kdeui/widgets/kmainwindow.cpp, branches/KDE/4.0/kdelibs/kdeui/xmlgui/kxmlguiwindow.cpp, branches/KDE/4.0/kdelibs/kdeui/widgets/kmainwindow_p.h, branches/KDE/4.0/kdelibs/kdeui/widgets/kmainwindow.h: Fix window roles for KMainWindow: - '#' in the window role is used by KWin to improve window grouping, so do the character-allowed-by-dbus only for the dbus name - don't prepend app name to it - it adds up with session restore - when name with # is given, try to use it as given first BUG: 156092 2008-01-22 20:53 +0000 [r764914] porten * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_html.cpp: Added missing break-out statement as noticed by Christop Bartoschek. 2008-01-23 12:05 +0000 [r765187] lunakl * branches/KDE/4.0/kdelibs/kdeui/windowmanagement/kwindowsystem_x11.cpp: Avoid crash with viewports. Announce desktop changes also when mapping viewports. 2008-01-23 17:29 +0000 [r765258] lunakl * branches/KDE/4.0/kdelibs/kdeui/windowmanagement/kwindowinfo_x11.cpp, branches/KDE/4.0/kdelibs/kdeui/windowmanagement/kwindowsystem_x11.cpp: Get global window position properly. 2008-01-23 17:54 +0000 [r765264] lunakl * branches/KDE/4.0/kdelibs/kdeui/windowmanagement/kwindowsystem_x11.cpp: Fix flags for _NET_MOVERESIZE_WINDOW. 2008-01-23 20:46 +0000 [r765313] lunakl * branches/KDE/4.0/kdelibs/kdeui/windowmanagement/kwindowsystem.h, branches/KDE/4.0/kdelibs/kdeui/windowmanagement/kwindowsystem_x11.cpp: Don't make viewport positions go outside desktop. 2008-01-23 22:38 +0000 [r765398-765389] orlovich * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_context2d.h, branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_context2d.cpp: Start of ImageData support. Has most of the JS bindings, and a first cut at getImageData (minus the security model for the moment --- hence will not go into SVN w/o followups) * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_context2d.cpp: - Implement putImageData - Use the array prototype on CanvasImageDataArray - Use proper composition mode in getImageData, fixing it.. Still need to do origin tainting... * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.h, branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Merge a commit by Fredrik: Rename FillPath and StrokePath to DrawPath and DrawStroke respectively, to avoid confusion with the fillPath variable in drawPath(). * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Merge a commit by Fredrik: Simplify and likely improve the correctness of the path and shadow bounding rect computations in CanvasContext2DImpl::drawPathWithShadow(). Don't generate the shadow image when the shadow is completely outside the canvas. * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Merge a commit by Fredrik: Use Qt::SvgMiterJoin instead of Qt::MiterJoin, since the SVG definition of a miter length seems to be a closer match to the HTML5 definition. * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Merge a commit by Fredrik: Throw INDEX_SIZE_ERR in CanvasContext2DImpl::drawImage() if the coordinates are invalid, as per the spec. * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Merge a commit by Fredrik: Change the code in CanvasContext2D::drawImage() so it no longer does an image copy when the source and destination rects don't have the same size. Don't go through drawPath() when we're not drawing a shadow, since that code path is slower. * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.h, branches/KDE/4.0/kdelibs/khtml/html/html_imageimpl.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_html.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_imageimpl.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_html.h, branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Implement cross-domain images tracking, and toDataURL. Still needs an audit before going into SVN. (Also name the token ID for getContext consistently) * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Use the CSS parser for color parsing, as specified, fixing many issues.. * branches/KDE/4.0/kdelibs/khtml/html/html_imageimpl.cpp, branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp, branches/KDE/4.0/kdelibs/khtml/imload/imageformat.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_context2d.cpp, branches/KDE/4.0/kdelibs/khtml/imload/image.cpp: Various canvas fixes: - Fix handling of null name arguments in createPattern - Properly verify all the attributes for non-zeroness when handling fake ImageData - More accurate premultiplication + some palette paranoia in imload - More compatible color serialization - Tighten the XSS check after discussion with dfaure - Update (c) years - Remove dead workaround/hack that's no longer relevant due to Qt being fixed 2008-01-24 18:35 +0000 [r765806] dfaure * branches/KDE/4.0/kdelibs/kdeui/shortcuts/kglobalaccel.cpp: Fix kded4 crash when doing RMB / Configure Shortcut on a menu item. (this method gets called for a shortcut that is not a global shortcut) 2008-01-24 18:45 +0000 [r765818] dfaure * branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel.cpp: to be on the safe side, fix the same crash inside kdedglobalaccel too, so that improper dbus calls don't make it crash. 2008-01-24 19:27 +0000 [r765848] dfaure * branches/KDE/4.0/kdelibs/kdeui/tests/kiconloader_unittest.cpp (added), branches/KDE/4.0/kdelibs/kdeui/tests/CMakeLists.txt, branches/KDE/4.0/kdelibs/kdeui/icons/kiconloader.cpp: Add first unittest for kiconloader; to check if it can find stuff in /appname/pics. It can. 2008-01-24 20:05 +0000 [r765865] winterz * branches/KDE/4.0/kdelibs/kdecore/util/kde_file.h: backport SVN commit 763261 by winterz: don't use the foo64 transitional extensions for _GNU_SOURCE. looks like GNU source is now largefile ready. 2008-01-24 20:45 +0000 [r765881] dfaure * branches/KDE/4.0/kdelibs/kdeui/tests/kwindowtest.cpp: fix crash 2008-01-24 20:47 +0000 [r765889-765885] orlovich * branches/KDE/4.0/kdelibs/khtml/test_regression.cpp: Make testregression independent of the installed image-missing icon, and make it use the older version, to reduce baseline fuzz. * branches/KDE/4.0/kdelibs/khtml/html/html_objectimpl.cpp: Don't improperly attach when not needed (fixes crash on #126285, which is different from the one reported. It's stable in 4.x after this, but I still need to analyze the 3.5.x one to be confident, since it's a weird one) CCBUG: 126285 * branches/KDE/4.0/kdelibs/khtml/misc/imagefilter.cpp: Merge a commit by Fredrik: Fix a bug with recoloring translucent shadows, and work around a QColor issue. * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.h, branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Merge a commit by Fredrik: Fix two regressions introduced by the new transformation semantics: * Don't transform the path in isPointInPath(), since it's already transformed. * Make pattern repeat modes work again with transformed patterns when shadows are enabled. 2008-01-24 21:04 +0000 [r765905] osterfeld * branches/KDE/4.0/kdelibs/kio/kio/slave.cpp: backport: do not crash when assertion fails 2008-01-24 23:22 +0000 [r765954-765953] ahartmetz * branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel.cpp: more precise crash guards * branches/KDE/4.0/kdelibs/kdeui/shortcuts/kglobalaccel.cpp: backport of commit 765953 (and some earlier one maybe, shame on you svnbackport!): more precise crash guards 2008-01-24 23:44 +0000 [r765964] ahartmetz * branches/KDE/4.0/kdelibs/kio/kio/tcpslavebase.cpp, branches/KDE/4.0/kdelibs/kio/kssl/ksslinfodialog.cpp: backport of trunk commit 765961: partially (it's a large part) fix the SSL info dialog 2008-01-24 23:54 +0000 [r765966] pino * branches/KDE/4.0/kdelibs/kdecore/kdebug.areas: add a debug areas for okular (tiff) 2008-01-25 08:42 +0000 [r766102] mlaurent * branches/KDE/4.0/kdelibs/kdeui/sonnet/dialog.cpp: Backport: Fix help button 2008-01-25 09:00 +0000 [r766111] pshinjo * branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/update-doc.docbook, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/underBSDLicense.docbook, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/help-menu.docbook, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/underX11License.docbook, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/underLGPL.docbook (added), branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/install-compile.docbook, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/user.entities, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/install-intro.docbook, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/underGPL.docbook, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/gpl-notice.docbook, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/underArtisticLicense.docbook, branches/KDE/4.0/kdelibs/kdoctools/customization/ko/entities/underFDL.docbook: Applying revision 766108's patch to stable branch 2008-01-25 13:21 +0000 [r766248] dfaure * branches/KDE/4.0/kdelibs/kio/DESIGN.metadata: Mention UseProxy metadata 2008-01-25 15:53 +0000 [r766330] ppenz * branches/KDE/4.0/kdelibs/kio/kio/kfileitemdelegate.cpp: Backport: Also do a wrapping if the text does not contain spaces. With the current Qt version nothing changes because of a bug in QTextLayout, but this will be fixed in Qt4.4 final and maybe backported to 4.3.x. 2008-01-25 20:27 +0000 [r766427-766425] orlovich * branches/KDE/4.0/kdelibs/khtml/css/css_base.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom_elementimpl.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_dom.cpp, branches/KDE/4.0/kdelibs/khtml/.krazy (added), branches/KDE/4.0/kdelibs/khtml/khtml_caret.cpp, branches/KDE/4.0/kdelibs/khtml/css/css_valueimpl.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom2_rangeimpl.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_html.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom_xmlimpl.cpp, branches/KDE/4.0/kdelibs/khtml/khtml_settings.cc, branches/KDE/4.0/kdelibs/khtml/html/html_elementimpl.cpp, branches/KDE/4.0/kdelibs/khtml/khtml_part.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_binding.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom_docimpl.cpp, branches/KDE/4.0/kdelibs/khtml/css/css_renderstyledeclarationimpl.cpp: Backport winterz's krazy annotations, to make it easier to check whether the branches are in sync * branches/KDE/4.0/kdelibs/khtml/misc/imagefilter.cpp, branches/KDE/4.0/kdelibs/khtml/misc/imagefilter.h: Merge Fredrik's work from trunk: Simplify the recoloring code in ImageFilter::shadowBlur(). * branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.h, branches/KDE/4.0/kdelibs/khtml/html/html_canvasimpl.cpp: Merge Fredrik's work from trunk: Transform the current position in the path back from device space when we need it instead of keeping an untransformed copy, otherwise we'll get the wrong results when the CTM is changed before a call to arcTo (and we already rely on the CTM being invertible in drawPath). Also add a set of mapToDevice/mapToUser convenience functions, and use them to transform points back and forth. 2008-01-26 20:46 +0000 [r766880-766879] orlovich * branches/KDE/4.0/kdelibs/khtml/khtmlview.cpp: Don't crash on drop in frames. Same deal as r739370, #151836 --- this was playing ping-pong-with Qt with drop events, trying to propagate them up, and Qt sending them back down because it doesn't match its internal DND state. Just as in khtmlimagepart, just let Qt bubble them itself. This makes behavior match KDE3.5.x --- one can drop things from different documents here, and that'll affect the document (one can't DND from one frame to another, but that was the case in 3.5.x, too, and it's probably the right thing to do..) * branches/KDE/4.0/kdelibs/khtml/ecma/kjs_window.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/debugger/debugwindow.cpp, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_window.h: Fix imprecision of timer events w/long-executing code. It was counting all code as potential pause, while the intent is to do it only for alerts and such. Hence, this makes the pausing explicit, and also preventing reentrancy. Pauses are on for alerts & co (and also used by the debugger). Things are still off by ~1.5-2ms, though. 2008-01-27 18:05 +0000 [r767278] orlovich * branches/KDE/4.0/kdelibs/kdeui/widgets/kmainwindow.h: I guess since we're using it outside kdelibs now, it better be documented... 2008-01-27 20:07 +0000 [r767329] uwolfer * branches/KDE/4.0/kdelibs/kdeui/dialogs/kmessagebox.cpp: Backport: SVN commit 767327 by uwolfer: Do only enable automatic wrapping for messages which are longer than one third of the current screen width. Otherwise some very short messages are displayed in three or more lines; only one word per line in some cases. You can still force line breaks with \n. #156780 2008-01-28 06:38 +0000 [r767492] mueller * branches/KDE/4.0/kdelibs/cmake/modules/KDE4Macros.cmake: fix symlink installation (backport from trunk) 2008-01-28 07:23 +0000 [r767502-767500] mlaurent * branches/KDE/4.0/kdelibs/kdeui/widgets/ktextedit.cpp: Backport: Fix improvment * branches/KDE/4.0/kdelibs/khtml/rendering/render_form.cpp: Use "document()->isEmpty()" to test if ktextedit is empty 2008-01-28 10:37 +0000 [r767559] dfaure * branches/KDE/4.0/kdelibs/kio/kio/jobuidelegate.h, branches/KDE/4.0/kdelibs/kio/kio/scheduler.h: Fix wrong docu (1 outdated, 1 wrong copy/paste) 2008-01-28 14:56 +0000 [r767696] alexmerry * branches/KDE/4.0/kdelibs/cmake/modules/FindFlac.cmake, branches/KDE/4.0/kdemultimedia/kioslave/audiocd/plugins/flac/encoderflac.cpp: Backport fix for FLAC > 1.1.2. CCBUG: 153503 2008-01-28 18:51 +0000 [r767770] dfaure * branches/KDE/4.0/kdelibs/kded/kbuildmimetypefactory.cpp: Remove wrong break which most certainly broke (hehe) reading mimetype translations. 2008-01-28 20:58 +0000 [r767818] ilic * branches/KDE/4.0/kdelibs/kdecore/localization/kuitsemantics.cpp: Recognize euro2 format as valid. (bport: 767816) 2008-01-29 09:46 +0000 [r768072-768071] amantia * branches/KDE/4.0/kdelibs/kdeui/widgets/ktabbar.cpp, branches/KDE/4.0/kdelibs/kdeui/widgets/ktabbar.h: Backport the "show close buttons on tabs" implementation. * branches/KDE/4.0/kdelibs/kdeui/widgets/ksqueezedtextlabel.cpp: Backport the KSqueezedTextLabel width fix. 2008-01-29 12:54 +0000 [r768116] mkretz * branches/KDE/4.0/kdelibs/phonon/platform_kde/kdepluginfactory.cpp: backport SVN commit 762478 by adridg: Somewhat hackish partial solution to the 'Unable to find a Multimedia Backend' hydra: only show the message *once* from each notofy process; this at least allows you to click 'ok' and get rid of them. 2008-01-29 13:22 +0000 [r768122] mkretz * branches/KDE/4.0/kdelibs/phonon/libkaudiodevicelist/hardwaredatabase: backport SVN commit 760365 by mkretz: Add entries for ATI SB450 HDA Audio and adjust name of similar device (soon I'll be able to write up some rules for consistent naming) and SVN commit 760372 by mkretz: And another device. Thanks for the report. 2008-01-29 15:19 +0000 [r768151] staniek * branches/KDE/4.0/kdelibs/kdecore/network/k3resolverstandardworkers.cpp: hasIPv6(): On windows use ::closesocket() instead of ::close() 2008-01-29 16:18 +0000 [r768230] orlovich * branches/KDE/4.0/kdelibs/kioslave/http/http.cpp: Do not issue both error and finished in response to one requests; that violates the KIO statemachine spec, and can lead to lack of synchronization, visually resulting in broken images.. 2008-01-29 17:20 +0000 [r768282] brandybuck * branches/KDE/4.0/kdelibs/cmake/modules/FindKDE4Internal.cmake, branches/KDE/4.0/kdelibs/cmake/modules/FindQt4.cmake: adjust order of includes 2008-01-29 23:13 +0000 [r768392] orlovich * branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.h, branches/KDE/4.0/kdelibs/khtml/ecma/kjs_traversal.cpp, branches/KDE/4.0/kdelibs/khtml/dom/dom2_traversal.cpp, branches/KDE/4.0/kdelibs/khtml/xml/dom2_traversalimpl.cpp: - actually follow the designed-in invariant for what happens during filter-induced mutations - always return the node that was passed to the filter.. 2008-01-30 00:59 +0000 [r768421] sengels * branches/KDE/4.0/kdelibs/kjs/JSImmediate.h: mingw++ 2008-01-30 11:20 +0000 [r768552] dfaure * branches/KDE/4.0/kdelibs/kdeui/actions/kaction.cpp: Implement Kevin's idea for the globalshortcuts-module-breaks-shortcuts problem: dynamic property 2008-01-30 11:29 +0000 [r768558] dfaure * branches/KDE/4.0/kdelibs/kdeui/xmlgui/kpartgui.dtd: noMerge is also available for ToolBar 2008-01-30 13:06 +0000 [r768605] mueller * branches/KDE/4.0/kdelibs/CMakeLists.txt: bump version 2008-01-30 15:25 +0000 [r768746] dfaure * branches/KDE/4.0/kdelibs/kdeui/actions/kstandardaction.h: mention quit vs closeAllWindows trap 2008-01-30 16:38 +0000 [r768784] pino * branches/KDE/4.0/kdelibs/CMakeLists.txt: typo in the release minor number 2008-01-30 16:38 +0000 [r768785] tokoe * branches/KDE/4.0/kdelibs/kimgio/eps.cpp: Backport of bugfix #156957 2008-01-30 16:45 +0000 [r768787] mueller * branches/KDE/4.0/kdelibs/CMakeLists.txt: trying this 2008-01-30 17:49 +0000 [r768811] dfaure * branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel_adaptor.h, branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel.cpp, branches/KDE/4.0/kdebase/workspace/kcontrol/keys/globalshortcuts.cpp, branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel.h: Patch from Aurélien which brings the empty actions (like KWin actions) back. He wrote: "I had to rework the way the kcm initializes itself. "The new implementation asks KdedGlobalAccel for the list of components, then for "the list of actions for each component. To do so it adds two methods to "KdedGlobalAccel: allComponents() and allActionsForComponent(). I also had "to remove all the "remove empty shortcuts" code from KdedGlobalAccel. 2008-01-30 18:01 +0000 [r768814] dfaure * branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel_adaptor.h, branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel.cpp, branches/KDE/4.0/kdelibs/kdeui/shortcuts/kglobalaccel.cpp, branches/KDE/4.0/kdebase/workspace/kcontrol/keys/globalshortcuts.cpp, branches/KDE/4.0/kdelibs/kdeui/shortcuts/kdedglobalaccel.h: # 2_{kdelibs,kdebase}_default_shortcuts.diff by Aurélien "This makes KdedGlobalAccel aware of the concept of default and active shortcuts. "It adds a new method: defaultShortcut(), which is used by the kcm to initialize the KAction correctly. 2008-01-30 19:09 +0000 [r768837] lunakl * branches/KDE/4.0/kdelibs/kio/kio/krun.cpp: Fix bnc:#343359 - it actually can cause trouble when using startup notification for non-compliant apps, even if silent :-/. 2008-01-30 19:29 +0000 [r768849] berendsen * branches/KDE/4.0/kdelibs/kate/syntax/data/lilypond.xml, branches/KDE/4.0/kdelibs/kate/syntax/data/language.dtd, branches/KDE/4.0/kdelibs/kate/tests/highlight.ly: Lilypond highlighting backport from trunk, including update for backgroundColor and selBackgroundColor in dtd 2008-01-30 21:58 +0000 [r768905] orlovich * branches/KDE/4.0/kdelibs/kio/kio/connection.cpp: Fix stalls on long file transfers: 1. Always re-enable socket notifiers when resuming the backend connection 2. Use the proper length when computing whether there is an another complete thing to read -- if we are waiting for payload, HeaderSize bytes is useless. 3. Do multiple reads immediately in a loop. w/o (3) throughput is pathetic, as the client can't keep up with the slave. BUG: 156259